createTopic error restructure #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. I think following the AggregateError spec is a good choice. Once you've fixed the issues with the tests, I'd be happy to merge this contribution. |
|
@Nevon fixed the tests. Can I start with restructuring Consumer API protocol errors as my team is more interested in the consumers? |
|
Before you start, I would just ask that you outline what scenarios you'd like to address in the linked issue. It's also good if you could make separate PRs for each scenario if you plan on addressing multiple ones - makes it easier to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a trial for #957
P.S. Will be fixing spec and test files