posfram--set-frame-position: also set position when frame size changed

[kiennq]

With poshandler set to posframe-poshandler-frame-bottom-right-corner, the posframe will not be displayed properly once a bigger frame has been displayed.
To repo this issue, try this snippet

(cl-labels ((show (content time)
              (run-at-time time nil
                           (lambda (content)
                             (with-current-buffer (get-buffer-create "*a*")
                               (erase-buffer)
                               (insert content))
                             (posframe-show (get-buffer-create "*a*")
                                            :poshandler #'posframe-poshandler-frame-bottom-right-corner
                                            :internal-border-width 1
                                            :internal-border-color "white"))
                           content)))
  (show "aaaaa" 1)
  (show "aa" 2))

And how it looks like

The problem is posframe-show will call posframe--set-frame-position and since the position is the same (relative from right edge and bottom), it will not trigger set-frame-position again.
Well, the child frame size does changed, so without calling set-frame-position, the position will be wrong.

We should also call set-frame-position when the frame displayed size is changed.

How it looks like after the fix

[kiennq]

@tumashu

[tumashu]

do you have signed gpl paper？ posframe is gnu-elpa package, need it

[kiennq]

do you have signed gpl paper？ posframe is gnu-elpa package, need it

Yes, I've signed it.

[tumashu]

(defvar-local posframe--last-posframe-size nil
  "Record the last size of posframe's frame.")

(defvar-local posframe--last-posframe-displayed-size nil
  "Record the last displayed size of posframe's frame.")

The two variable seem to do same job?

[kiennq]

(defvar-local posframe--last-posframe-size nil
  "Record the last size of posframe's frame.")

(defvar-local posframe--last-posframe-displayed-size nil
  "Record the last displayed size of posframe's frame.")

The two variable seem to do same job?

No, the posframe--last-posframe-size is recording max-height, min-height stuffs that are passed from caller to fit-frame-to-buffer. It's not guaranteed to be the same with actual posframe size.
On other hand, posframe--last-posframe-displayed-size is recording frame size after fit-frame-to-buffer. It's located in posframe--set-frame-position so it can be used to check if the frame size has been changed and re-trigger set-frame-position.

[tumashu]

maybe we can use posframe--last-posframe-size-1 and posframe--last-posframe-size-2, and show the different in docstring.

[kiennq]

maybe we can use posframe--last-posframe-size-1 and posframe--last-posframe-size-2, and show the different in docstring.

Hmm, shouldn't the name itself should be explainable? It's no problem for me to change the name like that, but it make code much harder to look.
On other hand, with current naming of displayed-size, it's clearly that this is posframe displayed size, and other thing is something else.

[tumashu]

merged, thanks!