Mixed authentication modes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure multiple authentication methods in order. This allows users to specify the preferred method of authentication, but provide a fallback if that fails.
| /** | ||
| * Ordered list of permitted authentication types | ||
| */ | ||
| private val configuredTypes = types.split(",").toSeq.map(_.trim) |
There was a problem hiding this comment.
Why do we do a toSeq here before the map?
"a,b,c,d".split(",").map(_.trim).view
|
lgtm @Primer42 |
|
this LGTM as well |
|
Verified locally, merging. thank you very much @asheepapart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure multiple authentication methods in order. This allows users to specify the preferred method of authentication, but provide a fallback if that fails.
We would rather not create service users in ldap for the purpose of interacting with collins, and this allows us to do without affecting existing users and perhaps providing flexibility for future adopters.
One note regarding the tests --
This test passes individually (i.e.
test-only util.security.MixedAuthenticationProviderSpec), but fails as part of the globalplay test. This is because configurations from previous tests bleed over between tests. At some point theauthentication_reference.conffile is being loaded and polluting the configurations for ldap, which makes the ldap provider actually attempt a lookup and fail.