Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile to build collins docker image #111

Merged
merged 1 commit into from
Jan 3, 2014

Conversation

discordianfish
Copy link
Contributor

This provides a Dockerfile and some docs to run collins on docker.

IMO this makes testing/trying out and deploying collins much easier.

(@oshu: You might be interested in this :))

@william-richard
Copy link
Contributor

Hi,
Do you think you could add a bit more explanation to your readme/markdown document? Perhaps a bit explaining what Docker is, and that it is a tool that you can optionally use to build and interact with Collins? I want to avoid new users getting confused, especially since it isn't strictly necessary to use Docker, the documentation doesn't mention it.
Thanks!

@discordianfish
Copy link
Contributor Author

Like this? Let me now if there is still something unclear.

@william-richard
Copy link
Contributor

Much better - I'm going to make one very minor edit and merge it in.
Thanks for the contribution!

@william-richard william-richard merged commit dddea58 into tumblr:master Jan 3, 2014
@discordianfish discordianfish deleted the dockerize branch April 1, 2014 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants