remove Ruby version clamping for collins-shell #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version check prevents collins-shell from running on Ruby 2.x, even though it works just fine. Instead of "fixing" the check, just remove it wholesale, on the premise that anyone who is still using Ruby 1.8 or 1.9.1 has it coming, and all newer versions should be supported.
|
I agree. 🍕 |
|
@matthiasr These look good to me too. |
to not break the Gem build.
|
@Primer42 done! Sorry, missed that reference. |
william-richard
pushed a commit
that referenced
this pull request
Apr 29, 2014
remove Ruby version clamping for collins-shell
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
remove Ruby version clamping for collins-shell
dalehamel
pushed a commit
to Shopify/collins
that referenced
this pull request
Jun 10, 2014
remove Ruby version clamping for collins-shell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version check prevents collins-shell from running on Ruby 2.x,
even though it works just fine.
Instead of "fixing" the check, just remove it wholesale, on the premise
that anyone who is still using Ruby 1.8 or 1.9.1 has it coming, and all newer
versions should be supported.