Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for collins to add/remove arbitrary attributes on an asset at provision time, on a per-nodeclass basis. I.e. lets say you want to tag all nodes that are development hosts with
DEVELOPMENT_MODE=true
, you could put this inprofiles.yaml
to have that attribute automatically set at provision time.Similarly, you can clear specific attributes on specific nodeclasses, if you want to ensure there are no undesirable effects at provision time. (i.e.
DEVELOPMENT_MODE
attribute creates undesirable behavior on your production DB nodes):The was this is written such that attributes specified in
clear_attributes
wont clobber any more important attrs set by collins (i.e. nodeclass). The ordering of what trumps what is, in order of trumpiness:attributes
map in profileclear_attributes
in profileFeature.deleteSomeMetaOnRepurpose
)Let me know what you guys think!