remove AddressPool cache #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maddalab @Primer42 @dallasmarlow Ive tested this via test suite, and also concurrently allocating IPs against 2 instances using the same DB to ensure no deadlocks or primary key constraints were violated, and noone attempts to allocate a duplicate IP. This seems good to go! |
|
LGTM, did you try getting rid of the google cache library? I think this is the only use for it? |
|
@maddalab the guava cache is actually a totally separate thing. The "cache" for IP address allocation in this case was actually only an in memory bit set. I looked into the guava thing but it seemed not related to ipam, and also a much bigger task. (I honestly don't fully understand what all its grafted itsself onto) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maddalab @Primer42 @dallasmarlow
This PR guts the AddressPool of all IP allocation functions, and the bitset "cache" that was being used. This process-local cache has to go in order to be able to do proper loadbalancing between collins instances.