Fix issue with invoking authentication twice #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Invoking authentication twice, once during form validation, and once during action execution, causes login to fail in systems using OTP (One time password) authentication schemes.
|
In general, this LGTM. How was it tested? |
|
LGTM. worth testing? |
|
Not sure how useful it is, but it's been tested in my environment and works |
|
thanks matt. Matt tested in an OTP setup with LDAP. I tested with file and db auth. |
yl3w
added a commit
that referenced
this pull request
Jun 10, 2015
Fix issue with invoking authentication twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Invoking authentication twice, once during form validation,
and once during action execution, causes login to fail
in systems using OTP (One time password) authentication
schemes.
@byxorna @defect @Primer42 @roymarantz @mattikus
#315