-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added input search field in top bar #330
Conversation
Thanks @maximedevalland I'll pull it down and test it. Gennaro was trying something like this and Laquan wanted it, so definitely worth merging @byxorna @Primer42 @defect @roymarantz |
@maximedevalland I tried this and am probably doing something incorrect. I did not see the browser make a request when I press enter on the search field. I'll try once more later. |
Also, its not readily apparent to the user that clicking the "Collins" link on the left takes you to the search page. Nor is it clear which field the search input up top is actually searching on (tag? hostname?). The search also isnt functional; it isnt sending any parameters when posting, so the resources page returned is totally unfiltered and just returns all assets |
@maddalab Is there anything I can do to help expedite the merge? |
Sorry. I'll definitely take a look tonight. |
@maximedevalland thank you for the change. I'll go ahead and merge. I'm going to build on this and make a couple of small changes. |
added input search field in top bar
No description provided.