Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added input search field in top bar #330

Merged
merged 3 commits into from
Jul 9, 2015
Merged

Conversation

maximedevalland
Copy link
Contributor

No description provided.

@yl3w
Copy link
Contributor

yl3w commented Jun 23, 2015

Thanks @maximedevalland

I'll pull it down and test it. Gennaro was trying something like this and Laquan wanted it, so definitely worth merging

@byxorna @Primer42 @defect @roymarantz

@yl3w
Copy link
Contributor

yl3w commented Jun 27, 2015

@maximedevalland I tried this and am probably doing something incorrect. I did not see the browser make a request when I press enter on the search field. I'll try once more later.

@byxorna
Copy link
Contributor

byxorna commented Jun 28, 2015

screen shot 2015-06-28 at 9 27 07 am

Looks like the margins are a bit screwy.

@byxorna
Copy link
Contributor

byxorna commented Jun 28, 2015

Also, its not readily apparent to the user that clicking the "Collins" link on the left takes you to the search page. Nor is it clear which field the search input up top is actually searching on (tag? hostname?).

The search also isnt functional; it isnt sending any parameters when posting, so the resources page returned is totally unfiltered and just returns all assets

@maximedevalland
Copy link
Contributor Author

Thanks for your feedback @maddalab @byxorna

I've fixed the css and placeholder but I don't why, the search is working great for me.

@maximedevalland
Copy link
Contributor Author

@maddalab Is there anything I can do to help expedite the merge?
Thanks

@yl3w
Copy link
Contributor

yl3w commented Jul 7, 2015

Sorry. I'll definitely take a look tonight.

@yl3w
Copy link
Contributor

yl3w commented Jul 9, 2015

@maximedevalland thank you for the change. I'll go ahead and merge. I'm going to build on this and make a couple of small changes.

yl3w added a commit that referenced this pull request Jul 9, 2015
added input search field in top bar
@yl3w yl3w merged commit ae44eae into tumblr:master Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants