Reintroduce caching into models #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 22, 2015 16:09
Summary: In testing in production, it was necessary to have domain model caching to avoid overwhelming the db with queries. This commit introduces caching back for domain models, in doing so makes the code more type checkable and adds fairly substantial and complete unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing in production, it was necessary to have domain model
caching to avoid overwhelming the db with queries. This commit
introduces caching back for domain models, in doing so makes
the code more type checkable and adds fairly substantial and
complete unit test.
This also make the following changes.
(a) When returning the results for a Asset.find call, load all assets
from database using a single query
(b) Use transient for lazy vals and caching of queries objects to
avoid making a db call for each invocation (where applicable)
(c) Introduce a permission to clear cache.
(d) Minor changes for uniform property access.
@Primer42 @defect @byxorna @roymarantz