fix timeout deprecation warning in collins client request #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Primer42 @maddalab @Primer42 @schallert @roymarantz |
|
LGTM - should this also be a minor version bump? |
|
Up to you @Primer42. I was going to leave it to those who can actually release the gem to make the decision (and commit) to bump the release when appropriate, as I cannot anymore :( |
|
@byxorna yeah if you do a version bump in this PR, once it's merged I'll make sure the new gem gets deployed to public rubygems. |
|
@Primer42 done. |
|
👍 for the code and version bump too. |
william-richard
added a commit
that referenced
this pull request
Jan 29, 2016
fix timeout deprecation warning in collins client request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/Users/gabe/code/collins/support/ruby/collins-client/lib/collins/api/util/requests.rb:82:inhttp_call': Object#timeout is deprecated, use Timeout.timeout instead.`This fixes that.