Add EXTRA_OPTS for extra java options which do not fit other types #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Due to an internal Tumblr project we are in need of adding extra flexibility to the init script. The sysconfig configuration file is handled by the users, starting with a very basic default. The need here is to allow certain java command line options which may not fit the categories otherwise specified. Most are very specific. APP_OPTS the most generic comes after sourcing of the sysconfig file so there's no much wiggle room.
@defect @roymarantz @qx-xp @komapa @byxorna @gtorre
Thanks a bunch,
Vincent