Make base_serial optional in LSHW parsing #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome and always bugged me since I have some assets with this showing up 3 times right now. |
roymarantz
approved these changes
Mar 8, 2017
drop duplicate BASE_SERIAL attrs add some docs and tooltips to attributes in show_overview fix some tooltips
byxorna
force-pushed
the
gabe-base-serial-optional
branch
from
b739933
to
e175f10
Compare
|
@roymarantz ack! ive rebased and squashed down. |
|
good enough. thanks |
|
Hot 🔥 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the BASE_SERIAL attribute isnt correctly filtered when reconstructing base LSHW attributes for display. This caused the
base_serialattribute to appear multiple times (one for each time it was inducted!), even though this attribute shouldn't have been displayed here at all (it should show up on the LSHW show page, not generic attributes).Ive also spiced up the asset overview page with some tooltips when the Label for an attribute doesnt match the Name, to make it easier to understand where the attribute comes from. Additionally, I've added some docs links to describe the classification, type, status, etc of an asset.
Fixes #477
cc @roymarantz @defect @qx-xp @michaeljs1990 @gtorre