Add Classification to asset API #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for finding what classification a nodeclass belongs to using the API. The tests are a little bit... a lot a bit messy however they cover the two cases well I believe.
Didn't break the test but changed one back to it's original style since this was not the goal of this PR.
michaeljs1990
commented
Apr 18, 2017
| "create a configuration asset and check that an asset matches" in new WithApplication(FakeApplication( | ||
| additionalConfiguration = Map( | ||
| "solr.enabled" -> false))) with AssetApiHelper { | ||
| override val assetTag = "node_classy" |
There was a problem hiding this comment.
I only have nodes with the utmost class.
There was a problem hiding this comment.
"classification":"bourgeoise"
byxorna
approved these changes
Apr 20, 2017
|
Just a bump on this 😆 we merged the docs but not the code.... that has to be a first for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for finding what classification a nodeclass belongs to using the API.
The tests are a little bit... a lot a bit messy however they cover the two cases well I
believe.
Closes #482
Docs #541