-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show overview broken out by interface capacities #548
Show overview broken out by interface capacities #548
Conversation
add a nicsBySpeed grouping for overview change language for nic counts add deprecation notice to hasGbNic methods
7e0ef52
to
4284a06
Compare
I like this since it will also work with the strange 25GbE and 50GbE cards that could pop up in the DC. Can we remove *GbNic functions all together instead of deprecating them? It looks like the only place they are used is in tests and show_overview.html which should be easy to switch over.
|
@michaeljs1990 yea, i was going to but wanted to put up the most simple diff first. I am game to gut those unnecessary methods. Next push will include that. |
@michaeljs1990 removed unnecessary methods :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥
Fixes #545
@michaeljs1990 This updates the show overview to indicate how many of each capacity interface are present. For example, if a machine has 4x1g and 1x10g interfaces, the show overview will reflect this in a terse manner. Similarly, a machine with 1x40g nic will show that it includes a 40g nic, instead of reporting it does not have a 10g.
cc @defect @roymarantz @gtorre @qx-xp
Homogenous interfaces:
Mixed interfaces: