Add support for NVMe disks in LSHW #565
Conversation
|
Plz post screenies of the hardware summary of a lshw report containing both pcie and scsi disks? |
|
Finally got around to grabbing screenshots :) Asset overview page: https://www.dropbox.com/s/5ggkw6om63aagv3/Screenshot%202017-08-08%2016.12.50.png?dl=0 |
|
Would be nice to aggregate the pcie disk capacity on overview page, so people dont have to do subtraction to figure out how much flash nvme there is in the box |
|
@byxorna Most flash drives (at least the ones we've been using) don't have their storage capacity in the lshw output for some stupid reason. Hence the sketchy I don't think it's worth implementing an aggregate flash capacity when it's going to be wrong in most cases anyway? |
|
The delta between total storage and scsi storage makes it look like we know how large the pcie storage is, but are just too lazy to display it. Id rather display the pcie storage count, and separately address that number being incorrect in some installs, personally |
|
@byxorna Done |
| @@ -250,6 +250,13 @@ | |||
| <td>SCSI Storage</td> | |||
| <td>@aa.lshw.totalStorage.toHuman</td> | |||
| </tr> | |||
| @if(aa.lshw.hasFlashStorage != true) { | |||
There was a problem hiding this comment.
is this logic backwards, or am i crazy? shouldnt it be @if(aa.lshw.hasFlashStorage)?
There was a problem hiding this comment.
Uh, yup. Pushed a commit from testing stuff 🤦♂️ One sec, i'll fix it.
Turns out that (at least some) NVMe flash storage is listed as
storagein the LSHW output instead ofmemorylike some other flash storage devices. This PR updates thediskMatcherto look for flash devices under both names.@byxorna @qx-xp @roymarantz @michaeljs1990