Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal UI #89

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Proposal UI #89

wants to merge 35 commits into from

Conversation

0xExp-po
Copy link
Contributor

  • first fix layout SEO error
  • create proposal page

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for testnet-tansu ready!

Name Link
🔨 Latest commit 51b220b
🔍 Latest deploy log https://app.netlify.com/sites/testnet-tansu/deploys/67367b77386d3e000865bb6d
😎 Deploy Preview https://deploy-preview-89--testnet-tansu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 79
Accessibility: 88
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for tansu canceled.

Name Link
🔨 Latest commit 51b220b
🔍 Latest deploy log https://app.netlify.com/sites/tansu/deploys/67367b77bd88aa0008d0ab63

@tupui
Copy link
Owner

tupui commented Nov 14, 2024

Thanks! Here are some feedbacks.

  • Add a button on the project page to go to the DAO (right before merging, we can hide or deactivate it and put a tooltip). Remember that we need one DAO per project. Proposals are per project. The url can look like
    tansu.dev/governance/?name=tansu
  • Change the path to tansu.dev/governance
  • For the status I think we just need these 4: Active, cancelled, approved, rejected. I don't think we really need a queued status.
  • I suppose that clicking on Ideas is not really functional now as nothing happens. For now we can also just do proposals if that's simpler. But keep in mind this for the future.
  • For the numbers just write the number without #.
  • I am not a fan of the blue for the numbers and approved proposals. What about violet for accepted? For the number, brown or grey or something else you can propose.
  • For the pagination we should not be able to click on next if there no other proposals.
  • Only show time for proposals which are active.
Screenshot 2024-11-14 at 00 47 11

Here say Tansu Governance in the green and remove Tansu DAO system. Tansu is the current project name. Going on Salib should then say Salib Governance.

@0xExp-po
Copy link
Contributor Author

regarding the title of the voting page, I'd like to say this page is for the all proposal list
I mean this is not the proposals only for a project such as Tansu or Salib.

@tupui
Copy link
Owner

tupui commented Nov 14, 2024

We don't want a page with all the proposals. What can be helpful later is to have groups of projects and yes there it could be helpful to list proposals from many projects.

For now we need one page per project. Same as we have one page information for each project.

@0xExp-po
Copy link
Contributor Author

okay then each project has several proposals and there is those proposals' list in project proposal page
right?

@0xExp-po
Copy link
Contributor Author

I've fixed all above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants