Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tables to improve filtering, context cancellation in list calls. Closes #60 #61

Merged
merged 11 commits into from
Oct 27, 2021
Merged

Update tables to improve filtering, context cancellation in list calls. Closes #60 #61

merged 11 commits into from
Oct 27, 2021

Conversation

Subhajit97
Copy link
Contributor

@Subhajit97 Subhajit97 commented Sep 17, 2021 •
edited
Loading

Changes Implemented

What's new?

  • Context cancellation and Compartment filtering for all tables

  • Paging limit changes for the below tables:

    • github_branch
    • github_commit
    • github_issue
    • github_my_gist
    • github_my_issue
    • github_my_organization
    • github_my_repository
    • github_my_team
    • github_pull_request
    • github_release
    • github_stargazers
    • github_tag
    • github_workflow

  • Filter changes for below tables:

    • github_branch
    • github_commit
    • github_issue
    • github_my_issue
    • github_my_repository
    • github_pull_request

Integration test logs

Logs 
N/A

Example query results

Results 
N/A

@Subhajit97 Subhajit97 self-assigned this Sep 17, 2021
@Subhajit97 Subhajit97 linked an issue Sep 20, 2021 that may be closed by this pull request
Update tables to improve filtering, context cancellation in list calls #60
Closed
@Subhajit97 Subhajit97 linked an issue Sep 20, 2021 that may be closed by this pull request
Add linter to run on pull_request, releases, merge to master #62
Closed
@Subhajit97 Subhajit97 marked this pull request as ready for review September 20, 2021 13:09
@cbruno10 cbruno10 requested review from LalitLab and removed request for cbruno10 October 26, 2021 16:55
LalitLab
LalitLab suggested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Subhajit97
Left few suggestions and a few questions I am doubtful about on changes

docs/tables/github_user.md Outdated Show resolved Hide resolved
github/table_github_branch.go Outdated Show resolved Hide resolved
github/table_github_commit.go Outdated Show resolved Hide resolved
github/table_github_organization.go Show resolved Hide resolved
github/table_github_repository.go Show resolved Hide resolved
github/table_github_user.go Show resolved Hide resolved
LalitLab
LalitLab approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LalitLab LalitLab merged commit ee7fd79 into main Oct 27, 2021
@LalitLab LalitLab deleted the update-opt-quals branch October 27, 2021 11:43
@bigdatasourav bigdatasourav restored the update-opt-quals branch November 10, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalitLab LalitLab LalitLab approved these changes

Assignees

@Subhajit97 Subhajit97

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Subhajit97 @LalitLab