Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Okta Identity Engine while fetching policies (#126) #134

Closed
wants to merge 3 commits into from
Closed

Add support for Okta Identity Engine while fetching policies (#126) #134

wants to merge 3 commits into from

Conversation

misraved
Copy link
Contributor

Example query results

Results 
Add example SQL query results here (please include the input queries as well)

@ParthaI
Copy link
Contributor

ParthaI commented Aug 7, 2024

FYI: The review comments provided in the original PR need to be addressed. Ref: #126 (review)

@misraved
Copy link
Contributor Author

misraved commented Aug 8, 2024

@ParthaI notes for the PR:

  • Why are we adding a new config argument engine_type? Does Terraform handle it similarly?
  • Can the engine_type config argument be specified by an environment variable?
  • Can we add new tables for the tables that would need a new engine type? Since the API structure differs, I am more inclined to add the new tables.

@misraved
Copy link
Contributor Author

Addressed in #139

@misraved misraved closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misraved @ParthaI @rodneysamuel