Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When waiting for pending cache item, if the cache does not contain the expected data, this is treated as a cache hit #511

Closed
kaidaguerre opened this issue Feb 9, 2023 · 0 comments
Closed

When waiting for pending cache item, if the cache does not contain the expected data, this is treated as a cache hit #511

kaidaguerre opened this issue Feb 9, 2023 · 0 comments

Comments

@kaidaguerre
Copy link
Contributor

No description provided.

kaidaguerre added a commit that referenced this issue Feb 9, 2023
@kaidaguerre
Fix query cache pending item mechanism. Closes #512. Closes #511
93c45a4 
Take quals into account when finding pending cache item to satisfy a cache request.
If completed pending item does not provide expected cache data, treat this as a cache miss (fix `err` variable shadowing bug)
Ensure the cache key of completed pending items is updated to match the cache key of the cache request which satisfies it
kaidaguerre added a commit that referenced this issue Feb 9, 2023
@kaidaguerre
Fix query cache pending item mechanism. Closes #512. Closes #511
0e4c215 
If completed pending item does not provide expected cache data, treat this as a cache miss (fix `err` variable shadowing bug)
Ensure the cache key of completed pending items is updated to match the cache key of the cache request which satisfies it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaidaguerre