Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nameservers not returned for .dk domains #16

Closed
emilstahl opened this issue Sep 1, 2021 · 7 comments · Fixed by #28
Closed

Nameservers not returned for .dk domains #16

emilstahl opened this issue Sep 1, 2021 · 7 comments · Fixed by #28
Assignees
Labels
bug Something isn't working

Comments

@emilstahl
Copy link

Describe the bug
Nameservers not returned for .dk domains. The domain is returned.

Steampipe version
Example: 0.7.3

Plugin version)
Example: 0.2.0

To reproduce
Run:

> select name_servers
from
  whois_domain
where
  domain in ('emilstahl.dk');
+------------------+
| name_servers     |
+------------------+
| ["emilstahl.dk"] |
+------------------+

Expected behavior
As a normal whois query returns:

Hostname:             ns1.simply.com
Hostname:             ns2.simply.com
Hostname:             ns3.simply.com
Hostname:             ns4.simply.com

The output should be:
["ns1.simply.com","ns2.simply.com","ns3.simply.com","ns4.simply.com"]

@emilstahl emilstahl added the bug Something isn't working label Sep 1, 2021
@e-gineer
Copy link
Contributor

e-gineer commented Sep 1, 2021

Thanks @emilstahl for using Steampipe and reporting this issue 🙂

interesting that it seems to return the domain as it’s own name server. I suspect this is actually an issue with the Whois parser library we are using, but will need to do more testing to see why.

WHOIS data tends to vary a lot by TLD so perhaps there is something different about the .dk data.

@emilstahl
Copy link
Author

Yeah, the DK whois format/server is custom. 👍

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 28, 2022
@emilstahl
Copy link
Author

@e-gineer Can you remove the stale label?

@e-gineer e-gineer removed the stale No recent activity has been detected on this issue/PR and it will be closed label Apr 29, 2022
@cbruno10 cbruno10 self-assigned this Jun 1, 2022
@cbruno10
Copy link
Contributor

cbruno10 commented Jun 1, 2022

Hey @emilstahl , sorry for the radio silence on this, we'll be taking a look at this issue in the next week or so, and will post any updates here.

@cbruno10
Copy link
Contributor

@emilstahl Sorry for the long wait on this issue. I ran some tests against emilstahl.dk using the latest version of the whois and whois-parser packages (these changes are in the update-whois-packages branch), and it seems like the way the WHOIS data is being returned is unexpected in the whois-parser package, so it incorrectly pulls out the nameservers as @e-gineer had suspected.

I've opened likexian/whois-parser#52 as a feature request for better parsing. If you have any other information, feel free to add comments to that issue as well, thanks!

cbruno10 added a commit that referenced this issue Jul 5, 2022
This commit also updates `whois` to v1.12.5 and `whois-parser` to v1.24.0
@emilstahl
Copy link
Author

Awesome. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants