Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #198:
'1.0'
(a string) would (correctly) suggestFloatField
1.0
(a float) would (wrongly) suggestIntegerField
This was probably due to this comparison in the
IntegerField.deserialize
method:As indeed
1 == 1.0
, this might be causing the wrongly type detection. Thus I'm suggestingis
instead — in other words1 == 1.0
passes, but1 is 1.0
doesn't.That fixes the issues and make tests suggested in the issue pass ; )