PBE-1524: automatically convert typescript to javascript in pre-commit

[canzhen]

Description

Fixes #PBE-1524

Changes

Add pre-commit hook to convert typescript to javascript for k6 test script for load testing purpose.

🚀 PR created with fotingo

[tagoro9]

Do we need the pre-commit hook to be that specific? Only looking at load test. I wonder if there is an existing pre-commit hook to run if there is a pacakge.json in the repo? Our standard is to have a build script in the pacakge.json instead of bundle

[tagoro9]

This might fail when running in CI since you would first have to ensure there is an npm install

[tagoro9]

Also, since this is only used in 1 repo today, you could define the pre-commit hook local to that repo until we know how to standardize this?

[canzhen]

@tagoro9 Good point, I added npm install. And I updated the script from bundle to build. I tested in the vehicle-search repo and it worked.

I wonder if there is an existing pre-commit hook to run if there is a pacakge.json in the repo?
Not sure if I understand your question, but for vehicle-search, there is a package.json in the root level. But within load-test/ folder there's its own package.json file for converting typescript and other stuff.

I've posted a thread in #proj-load-testing channel discussing about different approaches of this ts -> js automation. The other way is to directly commit to the .git/hooks but after some research it didn't seem like we can commit anything under .git, it's auto ignored by git. Happy to hear your thoughts!

[tagoro9]

Pre-commit lets you create hooks local to a repo without committing that folder

[canzhen]

Yes but I don't think the existing pre-commit doesn't do the converting part?

Edit: conversations were moved to slack channel. will close the PR because we haven’t standardized any of the load testing patterns to make it reusable across repos yet, so probably directly updating .pre-commit-config.yaml makes more sense other than creating a new hook and re-use it across repos.