Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping n-button inside n-upload will break n-button-group style #1102

Closed
equt opened this issue Sep 6, 2021 · 2 comments
Closed

Wrapping n-button inside n-upload will break n-button-group style #1102

equt opened this issue Sep 6, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@equt
Copy link
Collaborator

equt commented Sep 6, 2021

TuSimple/naive-ui version (版本)

2.17.1

Vue version (Vue 版本)

3.2.9

Browser and its version (浏览器及其版本)

Chrome(92.0.4515.159)

System and its version (系统及其版本)

macOS(11.2.3)

Node version (Node 版本)

Reappearance link (重现链接)

https://github.com/equt-playground/naive-ui-upload-inside-button-group

Reappearance steps (重现步骤)

  1. Wrap an n-button inside an n-upload component;
  2. Place the wrapped n-button inside an n-button-group.

Expected results (期望的结果)

The wrapped button should be viewed as transparent.

Actual results (实际的结果)

The wrapped button is not treated as a button anymore.

Remarks (补充说明)

For a live demo, see the playground.

@github-actions github-actions bot added the untriaged need to sort label Sep 6, 2021
@Volankey Volankey added bug Something isn't working and removed untriaged need to sort labels Sep 6, 2021
@07akioni
Copy link
Collaborator

07akioni commented Sep 6, 2021

I've a good idea to make this fixed. I need some time to make it work.

Alse the idea can make file list and trigger into different components.

<n-button-group>
  <n-upload abstract>
    <n-upload-trigger abstract #="{ handleClick }">
      <n-button @click="handleClick"></n-button>
    </n-upload-trigger>
    <n-modal>
      <n-upload-file-list />
    </n-modal>
  </n-upload>
  <n-button />
</n-button-group>

@07akioni 07akioni self-assigned this Sep 6, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 17, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 17, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 17, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 18, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 18, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 19, 2021
kev1nzh37 pushed a commit to kev1nzh37/naive-ui that referenced this issue Sep 19, 2021
07akioni added a commit that referenced this issue Sep 19, 2021
…pload-trigger` components (#1193)

* feat(upload): add `abstract` prop,  separate `upload-file-list` and `upload-trigger` components  (#1102)

* docs(upload): add `abstract` props docs and CHANGELOG (#1102)

* feat(upload): add upload tests (#1102)

* feat(upload): fix `upload-trigger` and `upload-file-list` bug (#1102)

* docs(upload): remove `upload-trigger`  abstract prop (#1102)

* feat(upload) fix upload-file-list method (#1102)

* feat(upload): fix lint (#1102)

Co-authored-by: kev1nzh <[email protected]>
Co-authored-by: 07akioni <[email protected]>
Co-authored-by: kev1nzh_ark <[email protected]>
@07akioni
Copy link
Collaborator

fixed in #1193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants