Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tree component] use onLoad, an infinite loop will occur if the isLeaf or children has not changed. #4038

Closed
amihhs opened this issue Nov 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@amihhs
Copy link

amihhs commented Nov 15, 2022

TuSimple/naive-ui version (版本)

2.33.5

Vue version (Vue 版本)

3.2.45

Browser and its version (浏览器及其版本)

Chrome(107.0.5304.107)

System and its version (系统及其版本)

window_10

Node version (Node 版本)

Reappearance link (重现链接)

https://github.com/amihhs/navie_tree_issue

Reappearance steps (重现步骤)

  1. pnpm i
  2. click tree node
  3. see browser log

Expected results (期望的结果)

only load once

Actual results (实际的结果)

loop load

Remarks (补充说明)

The situation will happen in a moment:
1.

async function loadHandle(node) {
    return false
}
async function loadHandle(node) {
   try{
    ...
    }
  catch(error){
    // Handle errors but do not continue to expose errors
   }
}
@github-actions github-actions bot added the untriaged need to sort label Nov 15, 2022
jizai1125 added a commit to jizai1125/naive-ui that referenced this issue Nov 16, 2022
@07akioni 07akioni added bug Something isn't working and removed untriaged need to sort labels Nov 20, 2022
jizai1125 added a commit to jizai1125/naive-ui that referenced this issue Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants