feature/form: add `show-label` prop #865

kev1nzh37 · 2021-08-13T08:15:42Z

vercel · 2021-08-13T08:15:46Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/6AfzVYc4G5WtfkV3i7zYTaCMAgGp
✅ Preview: https://naive-ui-git-fork-kev1nzh37-feature-form-tusimple.vercel.app

codecov · 2021-08-13T08:20:22Z

Codecov Report

Merging #865 (31591c3) into main (19282b6) will increase coverage by 0.03%.
The diff coverage is 85.71%.

❗ Current head 31591c3 differs from pull request most recent head 6277b82. Consider uploading reports for the commit 6277b82 to get more accurate results

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   44.38%   44.41%   +0.03%     
==========================================
  Files         509      509              
  Lines       12449    12454       +5     
  Branches     3498     3500       +2     
==========================================
+ Hits         5526     5532       +6     
  Misses       5914     5914              
+ Partials     1009     1008       -1

Impacted Files	Coverage Δ
src/form/src/Form.tsx	`29.41% <ø> (ø)`
src/form/src/FormItem.tsx	`29.13% <50.00%> (+0.78%)`	⬆️
src/form/src/utils.ts	`66.66% <100.00%> (+2.38%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19282b6...6277b82. Read the comment docs.

Volankey

实现参考一下 showRequireMark,form及form-item都应该有

CHANGELOG.en-US.md

CHANGELOG.zh-CN.md

kev1nzh37 · 2021-08-13T10:05:58Z

实现参考一下 showRequireMark,form及form-item都应该有

好的，明天我加一下

Co-authored-by: Yugang Cao <[email protected]>

XieZongChen · 2021-08-13T14:38:07Z

尝试给当前pr加一下测试吧

07akioni · 2021-08-13T14:48:15Z

加一个 Demo，然后按照我的理解，不展示 label 的情况下应该也没有 label 占位，所以样式也需要修改。

kev1nzh37 · 2021-08-14T01:46:19Z

收到。

src/form/src/FormItem.tsx

kev1nzh37 · 2021-08-17T16:34:20Z

似乎逻辑上有点问题，我明天继续看下。

kev1nzh37 · 2021-08-18T04:00:35Z

逻辑似乎不能融合进 mergedShowLabelRef, 因为 no-label 这个 class 和 label的内容没关系。把代码还原回来了。

…ture/form

lgtm-com · 2021-08-18T04:09:51Z

This pull request introduces 1 alert when merging 08f85c8 into 6530474 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

07akioni · 2021-08-18T16:39:57Z

LGTM

07akioni · 2021-08-18T16:40:38Z

CHANGELOG.en-US.md

+
+- `n-message-provider` add `container-style` prop
+- `n-form` add `show-label` prop, closes [#858](https://github.com/TuSimple/naive-ui/issues/858).


这个的位置得改一下，挪到没发布的版本

07akioni · 2021-08-18T16:41:10Z

CHANGELOG.zh-CN.md


+- `n-form` 新增 `show-label` 属性，关闭 [#858 ](https://github.com/TuSimple/naive-ui/issues/858)
 - `n-message-provider` 新增 `container-style` 属性


挪一下位置

src/form/demos/enUS/index.demo-entry.md

07akioni

这个是期望的效果。

我研究了一下，好像 label = false 就能关掉 label，这个是目前已经实现的，通过 n-form-item--no-label 这个类。我们未来只通过 show-label 来控制这个行为，然后不允许 label 传 bool了。剩下的和现在一致。

kev1nzh37 · 2021-08-18T17:45:14Z

这个是期望的效果。

我研究了一下，好像 label = false 就能关掉 label，这个是目前已经实现的，通过 n-form-item--no-label 这个类。我们未来只通过 show-label 来控制这个行为，然后不允许 label 传 bool了。剩下的和现在一致。

了解了，白天提交。

CHANGELOG.en-US.md

CHANGELOG.zh-CN.md

src/form/src/FormItem.tsx

src/form/demos/zhCN/show-label.demo.md

* feat(form): add show-label prop and test (tusen-ai#858) * docs(form): add show-label doc and fix form item label desc (tusen-ai#858) * Update CHANGELOG.en-US.md Co-authored-by: Yugang Cao <[email protected]> * Update CHANGELOG.zh-CN.md Co-authored-by: Yugang Cao <[email protected]> * feat(form): rewrite show-label and add tests (tusen-ai#858) * docs(form): add show-label demo (tusen-ai#858) * feat(form): change show-label computed (tusen-ai#858) * feat(form): fix show-label (tusen-ai#858) * feat(form): fix bug (tusen-ai#858) * feat(form): update show-label scripts (tusen-ai#858) * docs(form): update show-label order and label description (tusen-ai#858) * Apply suggestions from code review Co-authored-by: kev1nzh <[email protected]> Co-authored-by: Yugang Cao <[email protected]> Co-authored-by: kev1nzh_ark <[email protected]> Co-authored-by: 07akioni <[email protected]>

kev1nzh added 2 commits August 13, 2021 16:01

feat(form): add show-label prop and test (tusen-ai#858)

bf6581b

docs(form): add show-label doc and fix form item label desc (tusen-ai…

53e5136

…#858)

vercel bot deployed to Preview August 13, 2021 08:15 View deployment

Volankey requested changes Aug 13, 2021

View reviewed changes

CHANGELOG.en-US.md Outdated Show resolved Hide resolved

Talljack reviewed Aug 13, 2021

View reviewed changes

CHANGELOG.en-US.md Outdated Show resolved Hide resolved

CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved

Update CHANGELOG.en-US.md

90b842e

Co-authored-by: Yugang Cao <[email protected]>

vercel bot deployed to Preview August 13, 2021 10:06 View deployment

Update CHANGELOG.zh-CN.md

fc60b38

Co-authored-by: Yugang Cao <[email protected]>

vercel bot deployed to Preview August 13, 2021 10:10 View deployment

XieZongChen linked an issue Aug 13, 2021 that may be closed by this pull request

Form hide label props 隱藏表單label #858

Closed

kev1nzh added 2 commits August 14, 2021 16:30

feat(form): rewrite show-label and add tests (tusen-ai#858)

69bc5d0

docs(form): add show-label demo (tusen-ai#858)

af0b103

vercel bot deployed to Preview August 14, 2021 08:33 View deployment

Volankey reviewed Aug 15, 2021

View reviewed changes

src/form/src/FormItem.tsx Outdated Show resolved Hide resolved

feat(form): change show-label computed (tusen-ai#858)

8cbc8ac

vercel bot deployed to Preview August 17, 2021 11:30 View deployment

Merge branch 'main' into feature/form

6583def

vercel bot deployed to Preview August 17, 2021 11:34 View deployment

feat(form): fix show-label (tusen-ai#858)

21a941d

Merge branch 'feature/form' of github.com:kev1nzh37/naive-ui into fea…

08f85c8

…ture/form

vercel bot deployed to Preview August 18, 2021 04:05 View deployment

feat(form): fix bug (tusen-ai#858)

b698acb

vercel bot deployed to Preview August 18, 2021 05:27 View deployment

07akioni reviewed Aug 18, 2021

View reviewed changes

kev1nzh added 3 commits August 19, 2021 15:19

Merge branch 'main' into feature/form

5368ce1

feat(form): update show-label scripts (tusen-ai#858)

9b78802

docs(form): update show-label order and label description (tusen-ai#858)

31591c3

vercel bot deployed to Preview August 19, 2021 08:13 View deployment

07akioni reviewed Aug 19, 2021

View reviewed changes

CHANGELOG.en-US.md Outdated Show resolved Hide resolved

CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved

07akioni reviewed Aug 19, 2021

View reviewed changes

src/form/src/FormItem.tsx Show resolved Hide resolved

Apply suggestions from code review

6277b82

vercel bot deployed to Preview August 19, 2021 17:39 View deployment

07akioni merged commit b401ff4 into tusen-ai:main Aug 19, 2021

07akioni reviewed Aug 19, 2021

View reviewed changes

src/form/demos/zhCN/show-label.demo.md Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/form: add `show-label` prop #865

feature/form: add `show-label` prop #865

kev1nzh37 commented Aug 13, 2021

vercel bot commented Aug 13, 2021 •

edited

Loading

codecov bot commented Aug 13, 2021 •

edited

Loading

Volankey left a comment •

edited

Loading

kev1nzh37 commented Aug 13, 2021

XieZongChen commented Aug 13, 2021 •

edited

Loading

07akioni commented Aug 13, 2021

kev1nzh37 commented Aug 14, 2021

kev1nzh37 commented Aug 17, 2021

kev1nzh37 commented Aug 18, 2021

lgtm-com bot commented Aug 18, 2021

07akioni commented Aug 18, 2021

07akioni Aug 18, 2021

07akioni Aug 18, 2021

07akioni left a comment •

edited

Loading

kev1nzh37 commented Aug 18, 2021


		- `n-message-provider` add `container-style` prop
		- `n-form` add `show-label` prop, closes [#858](https://github.com/TuSimple/naive-ui/issues/858).


		- `n-form` 新增 `show-label` 属性，关闭 [#858 ](https://github.com/TuSimple/naive-ui/issues/858)
		- `n-message-provider` 新增 `container-style` 属性

feature/form: add show-label prop #865

feature/form: add show-label prop #865

Conversation

kev1nzh37 commented Aug 13, 2021

vercel bot commented Aug 13, 2021 • edited Loading

codecov bot commented Aug 13, 2021 • edited Loading

Codecov Report

Volankey left a comment • edited Loading

Choose a reason for hiding this comment

kev1nzh37 commented Aug 13, 2021

XieZongChen commented Aug 13, 2021 • edited Loading

07akioni commented Aug 13, 2021

kev1nzh37 commented Aug 14, 2021

kev1nzh37 commented Aug 17, 2021

kev1nzh37 commented Aug 18, 2021

lgtm-com bot commented Aug 18, 2021

07akioni commented Aug 18, 2021

07akioni Aug 18, 2021

Choose a reason for hiding this comment

07akioni Aug 18, 2021

Choose a reason for hiding this comment

07akioni left a comment • edited Loading

Choose a reason for hiding this comment

kev1nzh37 commented Aug 18, 2021

feature/form: add `show-label` prop #865

feature/form: add `show-label` prop #865

vercel bot commented Aug 13, 2021 •

edited

Loading

codecov bot commented Aug 13, 2021 •

edited

Loading

Volankey left a comment •

edited

Loading

XieZongChen commented Aug 13, 2021 •

edited

Loading

07akioni left a comment •

edited

Loading