Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating Action Button covers the last element of a scroll-list of toots. #1563

Closed
1 task done
m-zaink opened this issue Nov 17, 2019 · 0 comments · Fixed by #4486
Closed
1 task done

Floating Action Button covers the last element of a scroll-list of toots. #1563

m-zaink opened this issue Nov 17, 2019 · 0 comments · Fixed by #4486
Labels
bug

Comments

@m-zaink
Copy link

m-zaink commented Nov 17, 2019 •
edited
Loading

mastodon_issue_FAB

On profiles with fewer toots, when you scroll until the bottom of the toot list, the FAB (floating action button) for tooting covers the last toot.

This is particularly a bad user experience when a user tries to interact with that last toot.

Perhaps if each Scroll List is ended with an extra filler list-element, FAB won't cover the last element and everyone is catered to.

  • Tusky Version: 9.1

  • Android Version: 9.0.9

  • Android Device: OnePlus 5T

  • Mastodon instance (if applicable): mastodon.social

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@charlag charlag added the bug label May 10, 2022
@connyduck connyduck mentioned this issue Jun 2, 2024
Merged
connyduck added a commit that referenced this issue Jun 5, 2024
@connyduck
Replace "Hide compose button while scrolling" setting with bottom pad…
34b53a3 
…ding (#4486)

As discussed in our contributors meeting.

Advantages:
- last element of list never obscured by action button
- less code that runs on every scroll
- less settings to worry about

Additionally: 
- Added a (smaller) padding to the bottom of lists without action
button, I think it looks nice if there is a bit of white space and the
nav bar divider and the last list divider don't touch.
- The list of filters had no dividers, I added them.
- Recyclerviews with fixed height (Drafts, Filters, edits) now have
scrollbars
- code formatted all touched xml files

closes #1563

<img
src="https://github.com/tuskyapp/Tusky/assets/10157047/cd50199f-e84f-4402-93e4-a5a1beba2a08"
width="280"/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace "Hide compose button while scrolling" setting with bottom padding tuskyapp/Tusky
2 participants
@charlag @m-zaink