Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v21 regression: Black screen when playing audio #3261

Closed
1 task done
viviicat opened this issue Feb 4, 2023 · 2 comments · Fixed by #3286
Closed
1 task done

v21 regression: Black screen when playing audio #3261

viviicat opened this issue Feb 4, 2023 · 2 comments · Fixed by #3286

Comments

@viviicat
Copy link
Contributor

viviicat commented Feb 4, 2023 •
edited
Loading

  • Open an audio attachment such as the one on this post: https://solarpunk.moe/@vv/109562659215759090
  • Note that the screen appears black except for the header, which disappears after a second.
  • Tapping the screen does not cause the controls to reappear.
  • Audio plays but no controls are visible
  • Back button can be used to close the page.
  • if you go to another app and return sometimes the controls become visible but are not correctly set up.

I had previously written some code to improve audio playback (keep the timeline visible for audio) but it seems to have stopped functioning properly.

Screenshot_20230204-083439_Tusky
Screenshot_20230204-083224_Tusky
Screenshot_20230204-083309_Tusky

  • Tusky Version: 21.0

  • Android Version: Android 12 (lineage OS)

  • Android Device: Pixel 2

  • Mastodon instance (if applicable): any

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@viviicat viviicat changed the title Beta regression: Black screen when playing audio v21 regression: Black screen when playing audio Feb 5, 2023
@viviicat
Copy link
Contributor Author

viviicat commented Feb 5, 2023

Updated - this is still present on the 21 release.

@Lakoja
Copy link
Collaborator

Lakoja commented Feb 5, 2023

Can confirm this.

Audio (e. g. mp3) behaves in this way in Tusky (while video works fine).

efrohnhoefer added a commit to efrohnhoefer/Tusky that referenced this issue Feb 9, 2023
@efrohnhoefer
Update ViewVideoFragment.kt
fbc287f 
Testing
 - Open audio attachment: https://solarpunk.moe/@vv/109562659215759090
 - Ensure media control UI and alt text is shown once playback starts

Fixes tuskyapp#3261
@efrohnhoefer efrohnhoefer mentioned this issue Feb 9, 2023
Merged
@Lakoja Lakoja mentioned this issue Feb 9, 2023
Closed
1 task
connyduck pushed a commit that referenced this issue Feb 23, 2023
@efrohnhoefer
Fix media controller UI not showing during audio playback (#3286)
9e0ff78 
* Update ViewVideoFragment.kt

Testing
 - Open audio attachment: https://solarpunk.moe/@vv/109562659215759090
 - Ensure media control UI and alt text is shown once playback starts

Fixes #3261

* Fix commit issue

* Fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix media controller UI not showing during audio playback efrohnhoefer/Tusky
2 participants
@viviicat @Lakoja