Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseActivity.java::openAsAccount may be buggy #3702

Closed
1 task done
nikclayton opened this issue Jun 1, 2023 · 0 comments · Fixed by #3720
Closed
1 task done

BaseActivity.java::openAsAccount may be buggy #3702

nikclayton opened this issue Jun 1, 2023 · 0 comments · Fixed by #3720
Assignees

Comments

@nikclayton
Copy link
Contributor

openAsAccount changes the accountManager's activeAccount property, but does not do any of the work that AccountManager.setActiveAccount() does. In particular:

  • The current active account is not saved
  • The account passed as parameter here goes not have its isActive property set

This is probably a bug, per feedback on https://github.com/tuskyapp/Tusky/pull/3697/files#r1212176622, but needs proper investigation (it's called from a number of places which might depend on this behaviour).


  • Tusky Version: 21

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants