Improve language list prioritization #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses tuskyapp#3277
Lakoja
reviewed
Feb 12, 2023
|
|
||
| @Test | ||
| fun emptyInitialLanguagesAreDropped() { | ||
| val languages = getMockedInitialLanguages(arrayOf("", "", "fr", "", "kab", "")) |
There was a problem hiding this comment.
(curiosity)
Why are there empty languages?
Or I have seen null checks for locales in lists?
There was a problem hiding this comment.
The default post language and reply language can both be empty in normal usage
Lakoja
reviewed
Feb 12, 2023
| @Test | ||
| fun initialLanguagesContainReplySelectedAppAndSystem() { | ||
| val expectedLanguages = arrayOf<String?>("yi", "tok", "da", "fr", "sv", "kab") | ||
| val languages = getMockedInitialLanguages(expectedLanguages) |
There was a problem hiding this comment.
Shouldn't a test simply call the normal method with some test data?
(One wonders what is tested about a mocked list.)
There was a problem hiding this comment.
This function is a wrapper that mocks the response for querying the configured app and system languages, so that:
- the tests don't accidentally rely on whatever values robolectric returns
- we can verify the behavior of the code when it returns certain types of values
connyduck
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that all of (language of the post being replied to, default post language, configured app languages, configured system languages) are prioritized when constructing the language list for composing, regardless of whether any of those are languages android knows about.
Partially addresses #3277