2528: Do not remove notifications on general resume #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lakoja
commented
Feb 12, 2023
| @@ -117,7 +117,8 @@ class SendStatusBroadcastReceiver : BroadcastReceiver() { | |||
| builder.setCategory(NotificationCompat.CATEGORY_SOCIAL) | |||
| builder.setOnlyAlertOnce(true) | |||
|
|
|||
| notificationManager.notify(notificationId, builder.build()) | |||
| // There is a separate "I am sending" notification, so simply remove the handled one. | |||
| notificationManager.cancel(notificationId) | |||
There was a problem hiding this comment.
I wonder if there are more locations (special notifications) like this where notifications would not be removed now.
Upon creation (NotificationHelper#make) there are however only two special cases (compose and quick reply).
Lakoja
commented
Feb 12, 2023
| @@ -667,10 +666,6 @@ class MainActivity : BottomSheetActivity(), ActionButtonActivity, HasAndroidInje | |||
|
|
|||
| onTabSelectedListener = object : OnTabSelectedListener { | |||
| override fun onTabSelected(tab: TabLayout.Tab) { | |||
| if (tab.position == notificationTabPosition) { | |||
There was a problem hiding this comment.
Moved to NotificationsFragment.
connyduck
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely closes #2528