FilterResult.status_matches is a List<String>? #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is unclear what the correct type should be. The Mastodon documentation is inconsistent, it's either a `String?`, or a `List<String>?`. Getting this wrong crashes during JSON parsing. Since the field isn't used anywhere in Tusky yet it's easier to comment this out so it is not deserialized. This can be restored when mastodon/mastodon#24900 is fixed.
nikclayton
commented
May 8, 2023
Tak
approved these changes
May 8, 2023
connyduck
approved these changes
May 8, 2023
nikclayton
changed the title
|
They're updating the docs and confirmed it's |
|
I'd still argue for commenting it out, deserializing something that is not used is a waste of resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a Mastodon documentation bug, and is being fixed on their side in mastodon/mastodon#24900.