Save and restore the user's reading position more frequently #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code gets the user's reading position *once*, when the viewmodel is created, and uses that whenever it needs to be restored. This is a problem. Suppose the user is a few days behind on their notifications, and opens the app. The reading position is restored, as expected. They scroll up to start reading newer notifications. Then they change their notification filters. This causes the notifications list to change, and when it does their reading position is set back to what it was when they first switched to the Notifications tab. Fix this by: NotificationsFragment: - Save the reading position whenever the user stops scrolling. NotificationsViewModel: - Use the saved reading position whenever the list of notifications can change, not just when the view model is created.
nikclayton
commented
May 23, 2023
app/src/main/java/com/keylesspalace/tusky/components/notifications/NotificationsFragment.kt
Show resolved
Hide resolved
…ions/NotificationsFragment.kt
connyduck
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code gets the user's reading position once, when the viewmodel is created, and uses that whenever it needs to be restored.
This is a problem. Suppose the user is a few days behind on their notifications, and opens the app.
The reading position is restored, as expected. They scroll up to start reading newer notifications.
Then they change their notification filters. This causes the notifications list to change, and when it does their reading position is set back to what it was when they first switched to the Notifications tab.
Fix this by:
NotificationsFragment:
NotificationsViewModel: