Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle status edit histories with < 2 entries #3747

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Handle status edit histories with < 2 entries #3747

merged 4 commits into from
Jun 15, 2023

Conversation

nikclayton
Copy link
Contributor

This can happen if the edit history has not been propogated to the user's server.

Try and fetch the edit history from the original poster's server. This may succeed (if the status was public). If it doesn't then show a specific error message.

Fixes #3743

Nik Clayton added 2 commits June 13, 2023 13:29
This can happen if the edit history has not been propogated to the
user's server.

Try and fetch the edit history from the original poster's server.
This may succeed (if the status was public). If it doesn't then show
a specific error message.

Fixes #3743
@connyduck
Copy link
Collaborator

I'm very much against doing calls to instances other than the one the user logged in with.

  • It breaks privacy. As a user I would definitely not approve my client to leak my IP address to foreign instances. Also we would have to change our privacy policy.
  • Malicious instances could probably exploit this somehow e.g. by making Tusky load 1000s of images.
  • It only works with public posts on Mastodon Api compatible servers, but there are others
  • Opens the door for other calls to foreign instances, and that is complexity I would very much like to keep out of our code

@Tak
Copy link
Collaborator

Tak commented Jun 14, 2023

+1, we should never communicate with other instances

@nikclayton
Copy link
Contributor Author

OK. Updated to remove that feature and be more specific in the error message.

@nikclayton nikclayton requested review from Tak and connyduck and removed request for Tak June 15, 2023 09:18
@nikclayton nikclayton merged commit 100673a into tuskyapp:develop Jun 15, 2023
@nikclayton nikclayton deleted the 3743-missing-edit-history branch June 18, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes upon trying to view edit history
3 participants