Support code blocks #4090
Merged
Support code blocks #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tak
approved these changes
Oct 31, 2023
| return this.replace("<br> ", "<br> ") | ||
| .replace("<br /> ", "<br /> ") | ||
| .replace("<br/> ", "<br/> ") | ||
| .replace("\n", "<br/>") |
There was a problem hiding this comment.
Do we need to inject the nonbreaking space here? Or we only get \n when it's a code block?
There was a problem hiding this comment.
When a browser renders HTML, it ignores newlines as a default. The Android HTML parsing code does the same.
In a browser, you can override that behavior with the whitespace css property. Mastodon sets it for the whole status to pre-wrap. That difference did not matter, because Mastodon also replaces all newlines with <br/> so the Android parser would handle them correctly. But inside <code> blocks, newlines are not replaced by Mastodon, so that's what this replacement is for.
Tldr:
we only get \n when it's a code block?
yes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
