Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back the notification filter preference #4225

Merged
merged 1 commit into from
Jan 28, 2024
Merged

bring back the notification filter preference #4225

merged 1 commit into from
Jan 28, 2024

Conversation

connyduck
Copy link
Collaborator

It was probably forgotten when we restored the old notifications behavior.
closes #4222

@connyduck connyduck merged commit 0b9f61c into develop Jan 28, 2024
3 checks passed
@connyduck connyduck deleted the notifications_filter_pref branch January 28, 2024 18:07
@connyduck connyduck mentioned this pull request May 31, 2024
Merged
connyduck added a commit that referenced this pull request May 31, 2024
@connyduck
remove duplicate SHOW_NOTIFICATIONS_FILTER option (#4481)
16fbbc6 
The option was removed in #3877,
then forgotten to be added again in
#4015.
#4026 added it again, but took to
long to merge, so we made #4225 as
well and that is how we ended up with the option twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tak Tak Tak approved these changes

@mcclure mcclure Awaiting requested review from mcclure

@Lakoja Lakoja Awaiting requested review from Lakoja

@charlag charlag Awaiting requested review from charlag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to hide filter and delete buttons missing
2 participants
@connyduck @Tak