Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrofit 2.10.0 #4330

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Retrofit 2.10.0 #4330

merged 2 commits into from
Mar 19, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Mar 19, 2024

@Goooler Goooler marked this pull request as ready for review March 19, 2024 06:37
@connyduck
Copy link
Collaborator

Should we use NetworkResult<Unit> as a return type where we have NetworkResult<ResponseBody> now?

@Goooler
Copy link
Contributor Author

Goooler commented Mar 19, 2024

Good catch!

@connyduck connyduck merged commit 83cbbe9 into tuskyapp:develop Mar 19, 2024
3 checks passed
@Goooler Goooler deleted the retrofit-210 branch March 19, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connyduck connyduck connyduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goooler @connyduck