fix swipe-refresh spinner showing forever when refreshing AccountActivity #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
approved these changes
Mar 29, 2024
app/src/main/java/com/keylesspalace/tusky/components/account/AccountViewModel.kt
Outdated
Show resolved
Hide resolved
Tak
approved these changes
Mar 30, 2024
|
A better fix would be to set |
|
Yes, I just wanted a quick fix to get rid of the regression. There are probably more improvements possible in the account view, I want to have a look soon. PRs also welcome! |
Goooler
added a commit
to Goooler/Tusky
that referenced
this pull request
Apr 2, 2024
…ountActivity (tuskyapp#4345)" This reverts commit 5343766.
|
Fixing in #4353. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow must emit every update even if the values are the same, so use SharedFlow instead of StateFlow.
Regression from #4337 cc @Goooler