Replace Either with Kotlin Result and optimize ListUtils #4443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Either<Throwable, T>
is basically the same asResult<T>
with a less friendly API. Futhermore,Either
is currently only used in a single component.Either
withResult
inAccountsInListFragment
andAccountsInListViewModel
.NetworkResult
to aResult
inAccountsInListViewModel
. Alternatively,NetworkResult
could be used everywhere in the code but other classes are already usingResult
.updateState()
method withMutableStateFlow.update()
inAccountsInListViewModel
.MutableStateFlow
collected by a coroutine. This allows automatically cancelling the previous search when a new query arrives, instead of launching a new coroutine for each query which may conflict with the previous ones.ListUtils
.