Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kotlin to v2 #4461

Merged
merged 3 commits into from
May 23, 2024
Merged

Upgrade kotlin to v2 #4461

merged 3 commits into from
May 23, 2024

Conversation

connyduck
Copy link
Collaborator

No description provided.

@connyduck connyduck requested review from Tak and charlag May 22, 2024 18:05
Tak
Tak approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@Tak Tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I was expecting much more upheaval with this upgrade

@connyduck
Copy link
Collaborator Author

Yes, I was surprised as well. Only one minor compile error? Really? :D

@connyduck connyduck merged commit 78b1fcb into develop May 23, 2024
3 checks passed
@connyduck connyduck deleted the upgrade-kotlin branch May 23, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tak Tak Tak approved these changes

@charlag charlag Awaiting requested review from charlag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connyduck @Tak