Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translating posts via Mastodon api #4463

Merged
merged 6 commits into from
May 26, 2024
Merged

Conversation

connyduck
Copy link
Collaborator

This does 4 things:

  • Alt text is now translated when opening media of translated posts. Previously only the long-press alt text was translated.
  • The translate button is now hidden on non-public posts. The Mastodon api returns 403 there.
  • Translated posts will only be collapsible when the original was collapsible as well. It is just weird when an "show more" button suddenly appears because the post got longer by translating it.
  • The translation status and the untranslate button are now shown below each other instead of next to each other. Looks way better on smaller display or long texts.

Before / After

@connyduck connyduck requested a review from charlag May 23, 2024 19:39
@connyduck connyduck requested a review from Tak May 23, 2024 19:44
@connyduck connyduck changed the title Improve translations Improve translating posts via Mastodon api May 23, 2024
@connyduck connyduck merged commit 32dea86 into develop May 26, 2024
3 checks passed
@connyduck connyduck deleted the improve-translations branch May 26, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants