improved color scheme & theming #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lakoja
reviewed
Jun 12, 2024
app/src/main/java/com/keylesspalace/tusky/components/compose/view/ProgressImageView.kt
Outdated
Show resolved
Hide resolved
| * SwipeRefreshLayout does not allow theming of the color scheme, | ||
| * so we use this class to still have a single point to change its colors. | ||
| */ | ||
| class TuskySwipeRefreshLayout @JvmOverloads constructor( |
There was a problem hiding this comment.
Should(n't) this be a style file? And all swipe to refresh have that as "style"?
There was a problem hiding this comment.
You mean adding the missing styles here and then styling every SwipeRefreshLayout? Since the styling would be all the same and would need quite some additional lines of code I'd rather not.
There was a problem hiding this comment.
I was thinking how all the buttons for example are styled with some definition in styles.xml and then a "style=" on every usage.
But I couldn't find now how that might be done.
Lakoja
approved these changes
Jun 12, 2024
Tak
approved these changes
Jun 16, 2024
charlag
approved these changes
Jun 17, 2024
mcclure
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3921
tusky_blue, instead thecolorPrimaryattribute is used. This will help us when adding more themes, e.g a dynamic color one.colorPrimaryof the dark theme is now lighter for more contrast and subsequently thecolorOnPrimaryis now dark grey instead of white.tusky_red_lighteris now a bit more red than beforeI think this looks a bit unfamiliar but overall better and the higher contrast makes things noticeably easier to read.