Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detecting urls #4642

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Fix detecting urls #4642

merged 2 commits into from
Sep 2, 2024

Conversation

connyduck
Copy link
Collaborator

closes #4641

@connyduck connyduck changed the title Fix counting urls Fix detecting urls Sep 1, 2024
mcclure
mcclure approved these changes Sep 1, 2024
View reviewed changes
Copy link
Collaborator

@mcclure mcclure left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Yay tests. I have not tested on my phone but plan to test it later today and will close my issue then.

@mcclure
Copy link
Collaborator

mcclure commented Sep 1, 2024

Confirmed, branch fixes bug

@connyduck connyduck merged commit 4d73a3c into develop Sep 2, 2024
3 checks passed
@connyduck connyduck deleted the fix-counting-urls branch September 2, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcclure mcclure mcclure approved these changes

@Tak Tak Tak approved these changes

@charlag charlag Awaiting requested review from charlag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tusky URL detection breaks if capital letters in scheme://
3 participants
@connyduck @mcclure @Tak