Improve RTL support #964
Merged
Improve RTL support #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making these changes, texts in relevant pages will appear currectly in RTL layout.
|
But I see no difference? Rtl is already supported everywhere? Please explain what this improves, maybe with screenshots. |
|
The most please look at about page while your phone language is English and
compare it with what you see when phone language is Persian. Everything is
perfect except when a sentence starts with a Latin character. this makes
the text in the textbox appears LTR not RTL.
With my little change, this issue is resolved. If you need screenshot, I
will share one tonight.
…On Mon, Dec 24, 2018 at 3:40 PM Konrad Pozniak ***@***.***> wrote:
But I see no difference? Rtl is already supported everywhere? Please
explain what this improves, maybe with screenshots.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#964 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKuHY6KxfqkzE46-EYVPrBlJgwN7VbwOks5u8MQqgaJpZM4Zf76P>
.
|
|
This is the screenshot of the difference between current master branch and RTL-improve branch in about page.
|
|
Ah I see. Thank you! |
|
Didn't we have this discussion at #878 and decided against anyRTL? |
|
yes but #878 was about user generated content and this is about our interface (or am I missing something?) |
|
What I have done on about page, has solved the problem. But other commits
might be subject to the mentioned discussion.
I even think all my PR could be dropped and solve the problem by changing
the translation in a way it doesn't start with Latin character.
…On سهشنبه ۲۵ دسامبر ۲۰۱۸، ۲۳:۰۴ Konrad Pozniak ***@***.***> wrote:
yes but #878 <#878> was about
user generated content and this is about our interface (or am I missing
something?)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#964 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKuHY9LPgHr2Bk-xlIi5pAfavJyX26nbks5u8n2ygaJpZM4Zf76P>
.
|
|
thanks @ahangarha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making these changes, texts in relevant pages will appear currectly
in RTL layout.