Python 2.7 and 3.7 compatibility #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgaughan
commented
May 28, 2020
| @@ -18,7 +18,7 @@ def subdir_contents(path): | |||
|
|
|||
| setup( | |||
| name = "gitosis", | |||
| version = "0.2", | |||
| version = "0.3", | |||
|
is this project still maintained? |
|
I think it's safe to say it isn't, sadly. |
|
True. |
|
I've been considering forking the project completely, but I'd like to get @tv42's blessing first. Just haven't had the time. |
|
@kgaughan You are welcome to fork and maintain a more up-to-date version, but please use a different name. I have a slow-burn desire to write a Gitosis v2, with lessons learned in the intervening years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm pulling my previous #17 into this PR, which fixes up
setup.py.)This PR adds a small compatibility layer to gitosis that allows it to run on both Python 2.7 and Python 3 (though I've only tested it with 3.7 so far), along with porting the code to use that layer, and to use syntax that works on both Python 2.7 and Python 3.
Additionally, I took advantage of a few things, such as using the
fileobject returned byopen()as a context manager to simplify and clean-up some of the file-handling code, and removed the test for the standard templates, as more modern versions of git don't install these by default.I threw in a tox configuration file to aid with running the test suite.