Pluggable sspi-client

[Suraiya-Hameed]

Refactored sspi-client to go in hand with tediousjs/tedious#624 (native.js was moved from there)

To use windows integrated auth in tedious, the connection would be,

var NativeAuthProvider = require('sspi-client');
const connection = new Connection({
...
authProvider: NativeAuthProvider({securityPackage: 'negotiate'}),
...
})

@arthurschreiber Can you have a look at this?

TODO

• add tests for native.js
• set negotiate as default security package, if undefined

[arthurschreiber]

Heya @v-suhame 👋,

I'm really sorry I did not get to this sooner! 😞

What do you think about actually keeping the authentication provider for tedious and the sspi-client itself as separate modules? 🤔

The way sspi-client is written right now, it seems to be re-usable and not specific to tedious, which I believe is a good thing. Small, focussed modules is seen as a best practice in the Node.js ecosystem.

Whatever you decide here, I'll also leave a separate review for the code as it is proposed in this pull request. 😄

Also, on an unrelated note, I remember you suggested transferring sspi-client to the tediousjs organization -- I think that'd be a great idea! 👍

[arthurschreiber]

What do you think about removing the .js extension from the paths passed to the require calls?

[arthurschreiber]

What do you think about putting the version requirement for Node.js into the package.json file, and removing it from here? That'd allow you to get rid of the semver dependency as well.

[arthurschreiber]

What do you think about removing this whitespace here?

[Suraiya-Hameed]

What do you think about actually keeping the authentication provider for tedious and the sspi-client itself as separate modules?

👍 I'm thinking of doing the same for node-kerberos too, it will be easier to get the changes from its parent package

@tvrprasad can you transfer sspi-client to tediousjs at your convenience 😄 Thanks!

[tvrprasad]

@tvrprasad can you transfer sspi-client to tediousjs at your convenience 😄 Thanks!

If you can share the steps on how I may do that, I'll be happy to do that. Is there some permission I have that you don't that makes it necessary that I do it?

If you're able to do it, please go for it. You have my permission :-)

[Suraiya-Hameed]

I don't have the permission to transfer. You can refer https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/#transferring-a-repository-to-another-user-account-or-to-an-organization

[tvrprasad]

@v-suhame I got an error saying I don't have permission to create a repository under tediousjs. Can you give me permission so I can complete the transfer?

[Suraiya-Hameed]

I don't have that access either 😅
@arthurschreiber would be the right person for that.

[tvrprasad]

@arthurschreiber Can you just fork sspi-client and transfer to tediousjs? Or you can give me temporary permission to create a repository under tediousjs and I'll do the transfer.