Skip to content

Commit

Permalink
Make "Copy" buttons actual buttons
Browse files Browse the repository at this point in the history
This makes them keyboard-accessible. For mouse users, the only change
here is that the focus outline will remain on the button once clicked
(in future, this can be solved with :focus-ring, but for now this would
require a polyfill). the tooltip is explicitly hidden on `mouseleave`,
so even though the `<button>` retains focus after clicking, the tooltip
won't stay visible once mouse user moves away.
the mouse hover styles have explicitly not been make to also apply to
:focus, so as to minimise the visual impact for
mouse users (though the tooltip remains visible)
 - but due to the default outline and the custom tooltip, it
should be fairly clear when keyboard users set focus to a copy button
too.
  • Loading branch information
patrickhlauke authored and mdo committed Apr 16, 2017
1 parent bc0cf36 commit ea1d69c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
11 changes: 9 additions & 2 deletions docs/assets/js/src/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,16 @@

// Insert copy to clipboard button before .highlight
$('.highlight').each(function () {
var btnHtml = '<div class="bd-clipboard"><span class="btn-clipboard" title="Copy to clipboard">Copy</span></div>'
var btnHtml = '<div class="bd-clipboard"><button class="btn-clipboard" title="Copy to clipboard">Copy</button></div>'
$(this).before(btnHtml)
$('.btn-clipboard').tooltip()
$('.btn-clipboard')
.tooltip()
.on('mouseleave', function () {
// explicitly hide tooltip, since after clicking it remains
// focused (as it's a button), so tooltip would otherwise
// remain visible until focus is moved away
$(this).tooltip('hide')
})
})

var clipboard = new Clipboard('.btn-clipboard', {
Expand Down
1 change: 1 addition & 0 deletions docs/assets/scss/_clipboard-js.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
color: #818a91;
cursor: pointer;
background-color: transparent;
border: 0;
border-radius: .25rem;

&:hover {
Expand Down

0 comments on commit ea1d69c

Please sign in to comment.