Fix getSelectorFromElement when # is a selector (#21615)

* Fix getSelectorFromElement when # is a selector * Thanks to @vanduynslagerp remove regex to validate selector
twbs · Mar 19, 2017 · f2f2e39 · f2f2e39
1 parent f2f8051
commit f2f2e39
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/js/src/util.js b/js/src/util.js
@@ -112,13 +112,16 @@ const Util = (($) => {
 
     getSelectorFromElement(element) {
       let selector = element.getAttribute('data-target')
-
-      if (!selector) {
+      if (!selector || selector === '#') {
         selector = element.getAttribute('href') || ''
-        selector = /^#[a-z]/i.test(selector) ? selector : null
       }
 
-      return selector
+      try {
+        const $selector = $(selector)
+        return $selector.length > 0 ? selector : null
+      } catch (error) {
+        return null
+      }
     },
 
     reflow(element) {