Make $(document).tooltip({...}) without a selector throw an error

Closes #15484
twbs · Jan 5, 2015 · f6a837c · f6a837c · Darkseal · Jan 6, 2015
1 parent 0841028
commit f6a837c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/js/tests/unit/popover.js b/js/tests/unit/popover.js
@@ -225,4 +225,11 @@ $(function () {
       })
       .bootstrapPopover('show')
   })
+
+  test('should throw an error when initializing popover on the document object without specifying a delegation selector', function () {
+    throws(function () {
+      $(document).bootstrapPopover({ title: 'What am I on?', content: 'My selector is missing' })
+    }, new Error('`selector` option must be specified when initializing popover on the window.document object!'))
+  })
+
 })
diff --git a/js/tests/unit/tooltip.js b/js/tests/unit/tooltip.js
@@ -1107,4 +1107,10 @@ $(function () {
     $element.bootstrapTooltip('show')
   })
 
+  test('should throw an error when initializing tooltip on the document object without specifying a delegation selector', function () {
+    throws(function () {
+      $(document).bootstrapTooltip({ title: 'What am I on?' })
+    }, new Error('`selector` option must be specified when initializing tooltip on the window.document object!'))
+  })
+
 })
diff --git a/js/tooltip.js b/js/tooltip.js
@@ -52,6 +52,10 @@
     this.options   = this.getOptions(options)
     this.$viewport = this.options.viewport && $(this.options.viewport.selector || this.options.viewport)
 
+    if (this.$element[0] instanceof window.Document && !this.options.selector) {
+      throw new Error('`selector` option must be specified when initializing ' + this.type + ' on the window.document object!');
+    }
+
     var triggers = this.options.trigger.split(' ')
 
     for (var i = triggers.length; i--;) {