Investigate & probably file Firefox bug regarding Customizer file saving problem

[cvrebert]

Successor of #14750, since the setTimeout still hasn't fully fixed the problem.

[mlissner]

Seeing this as well on FF33. It's a real confusing one since another dev usually generates our CSS files. Today I tried to tweak them slightly using the link in bootstrap.min.css but couldn't for the life of me figure out how to download the new file. I almost got to the point of installing and configuring LESS myself...

[cvrebert]

I almost got to the point of installing and configuring LESS myself...

It's really not that hard..

[mlissner]

It's really not that hard..

Actually, it kind of is if you're not steeped in the Node ways[1], but that's not really what I was getting at. I guess my point is that I'm not the person that usually does the Bootstrap work and for me it was completely mystifying how to get a changed Bootstrap CSS file from the one I had, because I didn't realize for a while that the browser was silently failing.

Is it worth it and easy to put a simple warning in place:

If the download does not begin, there is an open issue with Firefox 33 and you may want to try a different browser. We're working on fixing this issue [link to this page].

That's help people like me that hadn't used the page before.

---

[1] Wait, what's npm? Oh, right, node's package manager. OK, I suppose I need Node installed for that, right? OK, should I install node via apt or is it changing so quickly that I need to install from something else? One hour slowly ticks by as weird installation issues are discovered and squished, and I haven't even figured out how to use LESS yet...

[hnrch02]

I think we can come back to this after 3.3.1 ships (which will happen most likely this week) because it no longer happens for me on master but I still get it on the live site.

[dyurchuk]

I realize I'm a rare case here, but I had no idea what files I was supposed to be getting from the Compile and Download button at the bottom of the page, unless I found this GitHub issue.

I've been trying to download a custom build for the last couple days and have been pulling my hair out wondering what's wrong. I wouldn't have guessed it was FireFox, but then again, this is my first time trying to download a custom BS build - I'm new to BootStrap. I kept wondering what to do with the config.json file generated and why wouldn't I be getting recompiled css, js, and font folders for the dist folder. I just wasn't getting the bootstrap.zip file. And most topics regarding the config.json just clarify it's only for retaining values for variables and less files to edit later. But I FINALLY got it generating a build correctly with Chrome.

But thinking it might be worth letting FireFox users know there's an issue or letting all users (on any browser) know exactly what files they will be generating and downloading by clicking that button. As of now, the only message is this:

"Hooray! Your custom version of Bootstrap is now ready to be compiled. Just click the button below to finish the process."

[mlissner]

@sistanoman, my experience exactly. 👍

[ghost]

I never faced Customizer file saving problem . I'm using latest FireFox.

[dyurchuk]

@rajlaksh - Well, for the record I JUST updated from FF 33.0.3 to FF 33.1 and NOW it's working great. Apparently, there's a conflict for sure with that previous release of FF. But thanks for reminding me to check for an update! ;)

Off topic, but FF is really pushing privacy features in the latest release.

[cvrebert]

Yeah, it seems to be downloading every time now with Firefox 33.1.
Is anyone still seeing problems after upgrading to Firefox 33.1?

[cvrebert]

Closing since Firefox 33.1 appears to have fixed this.
Please comment if you're seeing still seeing download problems with Firefox 33.1+ though.

[Mithgol]

I am still seeing this problem on Firefox 33.1 and also after an upgrade to Firefox 33.1.1.

[cvrebert]

@Mithgol On which OS?

[Mithgol]

Windows 7 Professional with Service Pack 1, 64-bit.

I've also noticed that my user agent string still says Firefox/33.0 but that's probably an attempt to prevent “fingerprinting”.

[XhmikosR]

I definitely don't have this issue with 31.1.1 and 34beta. @Mithgol you should share the customizer's URL/config.

[Mithgol]

Customizer URL : http://getbootstrap.com/customize/

Customizer's message:

Success! Your configuration has been saved to https://gist.github.com/eeaedc1dbcdcdc32b84c and can be revisited here at http://getbootstrap.com/customize/?id=eeaedc1dbcdcdc32b84c for further customization.

(And nothing else happens.)

[XhmikosR]

Works fine here using http://getbootstrap.com/customize/?id=eeaedc1dbcdcdc32b84c on Windows 8.1 64-bit, Firefox 34.0 64-bit.

[dyurchuk]

It was working fine for me, but it's been hit or miss since I last posted 2 weeks ago. Sometimes it works, sometimes it doesn't. Again, on a Macbook Pro w/ Yosemite, using latest FF 33.1.1.

Just continuing to use Chrome for now for my builds...

EDIT: Just want to clarify also, that it is the ZIP archive file I am not receiving; the custom URLs I'm getting.

[Mithgol]

I have seen that a gist URL is generated; that means createGist working correctly.

Therefore the problem has to be somewhere in lines 455—472 of the current customizer.js.

Demos of FileSaver.js work for me. Maybe the problem is not in saveAs.

[ghost]

Same here now its not giving me archive :(
I will check update to latest Firefox currently i'm using 33.1

Edit: with Latest Firefox it works.

[mlissner]

I was waiting for FF 34 to check this again and yes, I'm still seeing it.

Can a simple message be added to the customizer that says "click here to download" or if that's difficult, "If your download does not begin and you're using Firefox, try using Chrome"?

For Firefox users this is extremely confusing and totally and silently breaks the customizer. If it's hard to fix the customizer, at least we can provide a warning.

[Mithgol]

I believe that #15338 is the same issue.

Also, though @jdavies322 in #15338 and me here have observed the issue on a custom download, it does behave the same way when the download is not customized (at least for me), so the steps to reproduce the issue are actually quite simple:

1. Visit http://getbootstrap.com/customize/
2. Scroll to the bottom and hit the violet button “Compile and Download”.
3. Observe that nothing is prompted to be saved to your disk — though both the message “Success!” and the gist's URL appear.

[cvrebert]

@Mithgol That's understandable. The Customizer does the same stuff regardless of whether or not you actually modify any of the variable values.

[cvrebert]

Okay, we've now added a warning to the Customizer about this: #15395

[mlissner]

👍 Thanks very much!

[dyurchuk]

Great, thank you guys!

And, unfortunately, the latest FF 34.0.5 is still not triggering the download for me...

[ghost]

I got a trick. Just Press ALT to download file and works. Without it it fails to download archive.

[XhmikosR]

Interestingly, Alt + left click seems to indeed fix the issue.

[miketaylr]

Hi there, I work on compat stuff in Firefox and noticed the big banner tonight. I'm trying to find some STR, and just to confirm, this only happens on Windows? I'd like to get to the bottom of the bug and get it fixed in Gecko/Firefox, if possible.

[XhmikosR]

Personally, I can't really reproduce this anymore.

[jdavies322]

It's no longer an issue for me, but FYI it was Mac OS Firefox

[XhmikosR]

It happened on Windows too.
On May 21, 2015 5:07 PM, "jdavies322" [email protected] wrote:

It's no longer an issue for me, but FYI it was Mac OS Firefox

—
Reply to this email directly or view it on GitHub
#15016 (comment).

[Mithgol]

It happens to me if FlashGot is intalled in Firefox. Alt+Shift+click helps the download to bypass FlashGot and thus to bypass this issue.

[miketaylr]

@Mithgol which platform and version?

[miketaylr]

I can't reproduce with FlashGot on OSX. If it only happens with this add-on, it's probably an AddOn bug and should be reported here: https://forums.informaction.com/viewforum.php?f=2.

@mlissner, @sistanoman, @jdavies322 can you all test again? Do you happen to have FlashGot installed as well?

[Mithgol]

@miketaylr I am sure it happened on Windows XP. (I also have a vague memory of the same issue on Windows 7 64-bit, but that may be a false memory.)

However, I've just tried to reproduce this issue and could not experience this problem in Firefox 38.0.1 on Windows XP Professional SP3, though FlashGot 1.5.6.12 is installed.

Something is fixed.

[miketaylr]

Thanks for checking @Mithgol. Let's wait to hear from others to confirm, but it sounds like this bug disappeared.

[patrickhlauke]

@miketaylr the best kind of bug, eh?

[mlissner]

Yeah, I can't reproduce this anymore on Ubuntu, whereas I could consistently before. Perhaps it's time to remove the warning banner.

I'm on FF 38.0.

[miketaylr]

@patrickhlauke :)

Thanks @mlissner. I'll go ahead and open a PR to remove the warning.